When background is transparent, highlighted text not inverted

[npezza93]

In ZSH when you tab complete, you can tab through options. When you set xterms background to transparent(say you are on a dark background) the text color does not get inverted correctly on the v3 branch. Changing the foreground, cursor, or selection colors did not fix the issue.

Repro steps:

• Set xterms theme background to transparent
• jump into zsh
• tab complete a command

If that doesn't really make sense I've attached a gif to help to show what I'm talking about.

[Tyriar]

Transparent is no longer a valid background color. This is related to #936, previously black was just used as the default background color which breaks when the background is not black.

Did you call this to get into this state?

var term = new Terminal({
  theme: {
    background: 'transparent'
  }
});

[npezza93]

@Tyriar Yes, that is what I called to get into that state.

[npezza93]

Changing the background to 'none', yields the desired results and inverts the text color correctly. Closing.

[corwin-of-amber]

With #1236, transparent background is allowed. But text highlighted with "inverse video" is still rendered incorrectly (invisible text over white background).

[corwin-of-amber]

I take that back – this was fixed in 4.3.0!