Add winptyCompat addon #1096
Merged
Add winptyCompat addon #1096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lines are never trimmed, so even if the term's size is reduced it could contain empty lines at the end when wrapping is valid
parisk
approved these changes
Oct 31, 2017
chabou
added a commit
to chabou/hyper
that referenced
this pull request
Apr 5, 2018
chabou
added a commit
to vercel/hyper
that referenced
this pull request
Apr 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1095
This addon provides a workaround for wraparound mode not working in winpty. It works by flagging lines as wrapped when the last character in the terminal is not empty. See microsoft/vscode#32042 and the comments in the addon itself for more details on how it works.