Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use bang operator for array methods #1329

Merged
merged 1 commit into from
Mar 21, 2018
Merged

Use bang operator for array methods #1329

merged 1 commit into from
Mar 21, 2018

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Mar 12, 2018

Part of #1319

We can use the bang operator ! to get rid of the | undefined if we're sure that the type is not undefined.

@Tyriar Tyriar added this to the 3.3.0 milestone Mar 12, 2018
@Tyriar Tyriar self-assigned this Mar 12, 2018
@mofux
Copy link
Contributor

mofux commented Mar 21, 2018

LGTM 👍

@Tyriar Tyriar merged commit 4ab79c9 into xtermjs:master Mar 21, 2018
@Tyriar Tyriar deleted the 1319_bang_operator branch March 21, 2018 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Tyriar @mofux