Convert EventEmitter to TypeScript and add tests #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parisk
previously requested changes
Dec 30, 2016
| private _events: {[type: string]: ListenerType[]}; | ||
|
|
||
| constructor() { | ||
| this._events = this._events || {}; |
There was a problem hiding this comment.
Are there any chances that this._events has already a value here?
| this._events = this._events || {}; | ||
| } | ||
|
|
||
| // TODO: Merge addListener and on, no reason for an alias in a private component |
There was a problem hiding this comment.
Should we merge addListener and on before merging?
| } | ||
|
|
||
| // TODO: Merge removeListener and off, no reason for an alias in a private component | ||
| public removeListener(type, listener): void { |
There was a problem hiding this comment.
Should we merge removeListener and off before merging?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #335