Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Test Coverage #1093

Closed
kidunot89 opened this issue May 28, 2020 · 4 comments · Fixed by #1118, #1121, #1134, #1137 or #1138
Closed

Improve Test Coverage #1093

kidunot89 opened this issue May 28, 2020 · 4 comments · Fixed by #1118, #1121, #1134, #1137 or #1138
Assignees

Comments

@kidunot89
Copy link
Contributor

kidunot89 commented May 28, 2020

Feature Request

The alert and connector class have little to now coverage.

  • Alert types
    • image
  • Connectors
    • image

The plugin core classes have better coverage, but still aren't that good.
image
(Sorry about the artifact 🤦‍♂️)

@kasparsd
Copy link
Contributor

kasparsd commented Jul 7, 2020

@kidunot89 Would you like to keep this issue open until we're reached a certain test coverage range? Or can we close it in favour of individual tickets for specific parts of code?

@kidunot89
Copy link
Contributor Author

@kasparsd Let's leave this open until Code coverage is at an acceptable level. I also want to discuss what to do about parts of the code where simulation isn't really an option, like WP core update logging functionality.

@kasparsd
Copy link
Contributor

Looks like this keeps getting closed because of the Fixes #.... references in the pull requests @kidunot89 :)

@kasparsd kasparsd reopened this Aug 14, 2020
@kidunot89
Copy link
Contributor Author

🤦‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment