-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uploading emscripten wheels to pypi fails #96
Comments
Thanks @kafonek! |
@Waidhoferj how do you feel about hosting the emscripten wheel as an asset on the y-py release? I've put together a prototype of that over in https://github.com/kafonek/py-rust-fib/releases/tag/second-release has an example of a Python/Rust emscripten wheel attached as an asset. I used https://github.com/softprops/action-gh-release to create the release as a CI action triggered by a tag, but we could also manually attach an emscripten wheel as an asset when creating the release if you do that via the UI right now. |
@kafonek This is a good fix given the choices we have. Would you be able to alter the |
Yep I think https://github.com/softprops/action-gh-release fits the workflow in this repo. I'll tweak |
Think I got a prototype, will move this on over to ypy next. |
This looks great! Thanks for troubleshooting! |
Quick update, think I've got the ci actions working but I'll need to tweak the dependencies in pyproject.toml to make |
That makes sense. Maturin is a dev dependency and totally unnecessary for library users |
Wow exiting to see it running! |
Nooo! https://github.com/y-crdt/ypy/actions/runs/3566940726/jobs/5994217644
I did not see this coming. Apologies, I should have tried to upload an emscripten wheel to test pypi on another project. Looks like pypi/warehouse#10416 is relevant.
I'll revert the wasm build in ci/cd later today if someone else doesn't get to it first.
The text was updated successfully, but these errors were encountered: