Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin wasm wheel runner to ubuntu-20.04 #103

Merged
merged 1 commit into from
Dec 20, 2022

Conversation

kafonek
Copy link
Contributor

@kafonek kafonek commented Dec 19, 2022

When ubuntu-latest resolves to ubuntu-22.04, it fails to checkout Python 3.10.2 (https://github.com/y-crdt/ypy/actions/runs/3687267693/jobs/6240630198#step:3:10). I think it's best to try and build with 3.10.2 to match Pyodide. Workaround is to pin this task to ubuntu-20.04 runner, which works. Maybe a future Pyodide release will be built with a Python version that lines up with ubuntu-22.04 Python targets.

@kafonek kafonek marked this pull request as ready for review December 19, 2022 21:13
@kafonek
Copy link
Contributor Author

kafonek commented Dec 19, 2022

Example "release" set of actions over in my fork: https://github.com/kafonek/ypy/actions/runs/3735184567/jobs/6338130318

@Waidhoferj Waidhoferj self-requested a review December 20, 2022 01:18
@Waidhoferj
Copy link
Collaborator

@kafonek Thanks for working this out. Seems like a good solution.

@Waidhoferj Waidhoferj merged commit f859c88 into y-crdt:main Dec 20, 2022
@kafonek kafonek deleted the pin-wasm-build-to-ubuntu-20.04 branch December 20, 2022 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants