Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wheel builds for aarch64 and others #115

Merged
merged 6 commits into from
Feb 13, 2023
Merged

Conversation

kafonek
Copy link
Contributor

@kafonek kafonek commented Feb 4, 2023

Closes #114

https://github.com/PyO3/maturin-action has couple of links to CI files for other projects that build wheels with maturin. I thought https://github.com/milesgranger/pyrus-cramjam/blob/master/.github/workflows/CI.yml and https://github.com/messense/py-dissimilar/blob/main/.github/workflows/CI.yml looked really clean in particular. The py-dissimilar CI looks like it builds all the linux and linux-cross python versions in one run but when I tried that I got an error saying maturin couldn't find an interpreter (https://github.com/kafonek/ypy/actions/runs/4093394652/jobs/7058804065 vs one of their working runs https://github.com/messense/py-dissimilar/actions/runs/3968643400/jobs/6802077215)

I think running tests on the built wheels is a good idea, but leaving that for a follow-up PR. I also think adding y-py to the maturin-actions readme would be cool. I can put in that PR if you all are good with it.

Lastly, I want to say python-version: ["3.7", "3.11"] actually skips building wheels for 3.8, 3.9, 3.10? Or is there some magic in the github action matrix syntax that makes this work?

@kafonek
Copy link
Contributor Author

kafonek commented Feb 4, 2023

Link to an action with the aarch64 builds https://github.com/kafonek/ypy/actions/runs/4093450537

@davidbrochart
Copy link
Collaborator

Don't we need architecture: ${{ matrix.target }} here and there?

@kafonek
Copy link
Contributor Author

kafonek commented Feb 6, 2023

Yep you're right on the linux build. Doesn't look like there's a macos arch matrix, I see the same for py-dissimilar CI

@davidbrochart
Copy link
Collaborator

Lastly, I want to say python-version: ["3.7", "3.11"] actually skips building wheels for 3.8, 3.9, 3.10?

But wheels are on PyPI for these versions.
@Waidhoferj is publishing to PyPI really done from the CI? Also, could you add me as a maintainer on PyPI so that I can release?

@davidbrochart
Copy link
Collaborator

@Waidhoferj Can we make a release with aarch64 wheels?

@davidbrochart
Copy link
Collaborator

@Waidhoferj Could you add me as a maintainer on PyPI so that I can make a release?

@Waidhoferj
Copy link
Collaborator

I don't think I have authorization to add you. @dmonad would you be able to do this?

@davidbrochart
Copy link
Collaborator

Thanks, in the meantime could you make a release with this PR @Waidhoferj ? People not being able to install JupyterLab 3.6 is becoming critical.

@Waidhoferj
Copy link
Collaborator

Sure sounds good

@Waidhoferj Waidhoferj merged commit 0df9bfe into y-crdt:main Feb 13, 2023
@Waidhoferj
Copy link
Collaborator

@davidbrochart, it looks like some of these new changes are causing the publishing pipeline to fail

@kafonek
Copy link
Contributor Author

kafonek commented Feb 13, 2023

Come on CI, why are you so difficult. That step ran fine when I tested the actions on my branch https://github.com/kafonek/ypy/actions/runs/4093450537/jobs/7058899187

@kafonek
Copy link
Contributor Author

kafonek commented Feb 13, 2023

Hmmmm, or the action on my branch is not using the architecture I expected it to
image

I must have run that action before the architecture fix @davidbrochart pointed out.

@kafonek
Copy link
Contributor Author

kafonek commented Feb 13, 2023

I'm debugging this now, I'll put up a new PR. If you want to open a new issue for the failing CI, I can post updates over there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide wheels for linux/arm64 (aarch64)
3 participants