Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Boolean Encoding #20

Merged
merged 1 commit into from
Mar 31, 2022
Merged

FIX: Boolean Encoding #20

merged 1 commit into from
Mar 31, 2022

Conversation

Waidhoferj
Copy link
Collaborator

  • Fixed type conversion bug that casted bools as integers
  • Added YDoc encoding and tutorial tests
  • Added StateVector and YDocUpdate type annotations for clearer hints
  • Updated README tutorial to reflect the current API

@Waidhoferj Waidhoferj added bug Something isn't working enhancement New feature or request labels Mar 31, 2022
@Waidhoferj Waidhoferj self-assigned this Mar 31, 2022
@Waidhoferj Waidhoferj mentioned this pull request Mar 31, 2022
Closed
dmonad
dmonad approved these changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@dmonad dmonad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick fix!

@Waidhoferj Waidhoferj merged commit 101c596 into main Mar 31, 2022
@Waidhoferj Waidhoferj deleted the fix-boolean-encoding branch March 31, 2022 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmonad dmonad dmonad approved these changes

@davidbrochart davidbrochart Awaiting requested review from davidbrochart

Assignees

@Waidhoferj Waidhoferj

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Waidhoferj @dmonad