Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YMap Items View #65

Merged
merged 2 commits into from
Jul 8, 2022
Merged

YMap Items View #65

merged 2 commits into from
Jul 8, 2022

Conversation

Waidhoferj
Copy link
Collaborator

Fixes #58
To more closely mirror the functionality of dict.items(), YMap.items() now returns an ItemsView:

  • Stays up to date with changes in the YMap
  • Supports length and membership checks in constant time
  • Supports multiple iterations, instead of getting exhausted like a standard iterator.

@Waidhoferj
YMap Items View
91c4ef2 
Fixes #58
To more closely mirror the functionality of dict.items(), YMap.items() now returns an ItemsView:
- Stays up to date with changes in the YMap
- Supports length and membership checks in constant time
- Supports multiple iterations, instead of getting exhausted like a standard iterator.
@Waidhoferj Waidhoferj added the enhancement New feature or request label Jul 3, 2022
@Waidhoferj Waidhoferj self-assigned this Jul 3, 2022
@Waidhoferj
Copy link
Collaborator Author

Waidhoferj commented Jul 8, 2022 •
edited
Loading

Fixes #57
Added KeysView and ItemsView. Similar to ItemsView, these are returned from the new keys() and values() methods for YMap

@Waidhoferj Waidhoferj linked an issue Jul 8, 2022 that may be closed by this pull request
Mappings are missing keys() and values() methods #57
Closed
@Waidhoferj Waidhoferj merged commit 9fa1559 into main Jul 8, 2022
@Waidhoferj Waidhoferj deleted the ymap-items-view branch July 8, 2022 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmonad dmonad dmonad approved these changes

@Horusiath Horusiath Awaiting requested review from Horusiath

Assignees

@Waidhoferj Waidhoferj

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

items() should return an itemview Mappings are missing keys() and values() methods
2 participants
@Waidhoferj @dmonad