Build WASM wheel #91
Merged
Build WASM wheel #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
friendly ping to @davidbrochart or @DerThorsten for review, thanks! |
|
Sorry for the late answer @kafonek, I think Thorsten is the best person to review this. |
|
looks good to me, but disclaimer: I know nothing about rust |
|
Maybe @Waidhoferj wants to have a look too? |
Waidhoferj
approved these changes
Nov 25, 2022
|
Thanks all, thanks for merging @Waidhoferj . I'm also excited to write up some demo's of y-py on client (pyodide) and server (fastapi). Are you going to bump the version, or want to manually push out the 0.5.4 emscripten wheel to pypi? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #90.
I believe Pyodide needs a wheel built with a specific version of Python and specific version of emscripten that match the Pyodide version. For latest Pyodide (0.21.3, released Sep 15 2022), and going back through Pyodide 0.20.0 (Aug 9) that is Python 3.10.2 and emscripten 3.14.1. If we wanted to support earlier versions, we would need to review Pyodide changelog to make a matrix of python/emscripten versions to build the wasm wheel with.
See https://github.com/kafonek/ypy/actions/runs/3452230687/jobs/5761992236 for an example of the wheel being built. I don't understand why that's building a wasm wheel for py310 and py311 there but it doesn't hurt anything 🤷♂️ .