Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cannot handle single quote (') string attributes with double quote (") in content #64

Open
Akronae opened this issue Mar 3, 2024 · 0 comments
Open

cannot handle single quote (') string attributes with double quote (") in content #64

Akronae opened this issue Mar 3, 2024 · 0 comments

Comments

@Akronae
Copy link

Akronae commented Mar 3, 2024

This example will fail:

fn main() -> () {
    let str = r#"<!DOCTYPE html>
    <html>
      <body>
        <meta data-mw='{"autoGenerated":true}' />
        hey
      </body>
    </html>
    "#;

    let dom = tl::parse(str, Default::default()).unwrap();
    let parser = dom.parser();
    let inner_html = dom
        .children()
        .get(1)
        .unwrap()
        .get(parser)
        .unwrap()
        .inner_html(parser)
        .to_string();

    dbg!(inner_html);
}

<meta data-mw='{"autoGenerated":true}' />
will be changed to
<meta data-mw="{"autoGenerated":true}">

due to incorrect single quote to double quote substitution, thus the tag is left open and is messing with the entire DOM.

Took me quite some time to realize what was happening.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Akronae