-
-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump serialport package version to ^11.0.0 #501
Conversation
Bump version to fix an issue on ARM platforms
Thanks ! |
Can you make a new release? |
The test suite is broken since this was merged |
Ah, it was apparently ninja-fixed in 33b52c0 |
|
Sadly, after bumping from 8.0.11 to 8.0.12, Modbus RTU no longer works properly:
|
can you find the issue ? |
I'm not sure, it must be related to the serialport version bump. I'd pull the release for now. |
ok 8.0.12 is detracted |
#505 similar report |
Bump version to fix an issue on ARM platforms
@Jalle19 can you try https://www.npmjs.com/package/modbus-serial/v/8.0.13 ? |
Seems to work! I can't find the relevant commits here on GitHub though, what did you change? |
I reverted #507 |
looks like this was the offending code: |
There is an upstream error with a certain binary release of the serialport package. It was caused by a maintainer updating libc and this broke cross-compilation on ARM targets and hence a faulty release binary was circulated into the wild. (It was fixed here: fix: update build tools and fix arm64 build for rpi by reconbot · Pull Request #111 · serialport/bindings-cpp).
Some additional reports are here:
node-red-node-serialport node makes the Docker container infinite boot cycle · Issue #894 · node-red/node-red-nodes
serialport@10.3.0 fails in docker container on rpi · Issue #2438 · serialport/node-serialport
Node-RED (Docker) crashes when /dev/ttyACM0 is configured in flow - Raspberry Pi 4 · Issue #3461 · node-red/node-red
The issue is fixed in version 11.0.0