linkValidaton encodes URL

[cruzanmo]

Description

Not sure why linkValidation is encoding the URL?

medium-editor/src/js/extensions/anchor.js

Line 246 in d880685

return (urlSchemeRegex.test(value) ? '' : 'http://') + encodeURI(value);

Steps to reproduce

1. add an anchor button with linkValidation: true
2. select text and add a link that has encoded characters, e.g. http://site.com/?q=http%3A%2F%2Fsite2.com
3. click checkmark to save link to text.

Expected behavior:
Text should have a link as entered: <a href="http://site.com/?q=http%3A%2F%2Fsite2.com">text</a>

Actual behavior:
Link is encoded: <a href="http://site.com/?q=http%253A%252F%252Fsite2.com">text</a>

Versions

• medium-editor: 5.22.0
• browser: all
• OS: all

[j0k3r]

Might be related to #1025

It's mostly to handle url that contains spaces.
Maybe we should go with value.replace(/\s/g, '%20') to only replace spaces?

[cruzanmo]

Looks like it used to be a regex like that: 5a9f383

If spaces are encoded, then everything should probably be encoded.

Hmm, the solution might be to check if the URL was already encoded, and then only encode if it was not already encoded.