Build breaks in a CommonJS environment

[dypsilon]

The dist breaks any build which has a module object defined. This object is always defined in a CommonJS environment. The error I get is:

Uncaught ReferenceError: process is not defined

This error results from this check:

var isElectron = typeof module === 'object' && process && process.versions && process.versions.electron;

module is an object because we have CommonJS but process is undefined because we are neither in node.js, nor in electron.

This issue is related to #1123.

[paradite]

looks like this just needs an additional check && typeof process !== 'undefined' before && process?

[j0k3r]

Yep think so!

[paradite]

I've opened a PR for this.