Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide how to proceed regarding DER keys format #82

Open
yago-123 opened this issue Jan 6, 2025 · 0 comments
Open

Decide how to proceed regarding DER keys format #82

yago-123 opened this issue Jan 6, 2025 · 0 comments

Comments

@yago-123
Copy link
Owner

yago-123 commented Jan 6, 2025

Right now we make use of DER encoded []byte private and public keys for wallets. The problem of this is that in some cases we must get rid of this encoding because we have to treat the keys with a raw format, example: handling the key derivation in hierachical deterministic wallets (which turns into something a bit ugly).

DER format have the advantage that provides additional metadata to the keys. This means that for example we can know which type of curve is a key with ECDSA algorithm. This is positive and negative thing. One bad thing is that we still use []byte format, which in some cases can create confusions with which type are we working with (DER encoded or raw).

Think about this and address somehow, a new type for DER formated keys could be created or maybe DER format must go away if the value added is not enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant