Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React.createClass deprecated on React 15.5.0 and above #528

Closed
J-Dickson opened this issue Apr 10, 2017 · 8 comments
Closed

React.createClass deprecated on React 15.5.0 and above #528

J-Dickson opened this issue Apr 10, 2017 · 8 comments

Comments

@J-Dickson
Copy link
Contributor

J-Dickson commented Apr 10, 2017

Information about the Issue

React.createClass is deprecated in React 15.5.0, therefore the React.createClass in NavLink causes a deprecation warning for any users on this version of React.

This will become a breaking change in React 16.0.0.

Are there plans to make this change in the project?

Thanks

@kaesonho
Copy link
Contributor

kaesonho commented Apr 10, 2017 via email

@redonkulus
Copy link
Contributor

Thanks for the report. We need to migrate all the code to es6 classes but that will take time if the components use mixins. In the meantime, we can use their new react-create-class package to remove the spam.

@J-Dickson
Copy link
Contributor Author

J-Dickson commented Apr 10, 2017

Hi, thanks for your reply. Would you like me to do a PR? @redonkulus

@redonkulus
Copy link
Contributor

redonkulus commented Apr 10, 2017

Sure thing. Along with fluxible-router, we will need fluxible-addons-react updated as well if you can do that too.

@redonkulus
Copy link
Contributor

Related facebook/react#9384

@J-Dickson
Copy link
Contributor Author

Here is the PR: #530

@redonkulus
Copy link
Contributor

Closed via #530

@redonkulus
Copy link
Contributor

@J-Dickson fluxible-router@1.1.0 and fluxible-addons-react@0.2.10 published with these changes. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants