Compatibility with newer "yargs" versions

[khitrenovich]

In Sep 2017 yargs released v9.0.0, which introduced breaking changes - help and version are now always added to argv object. This change is incompatible with protractor-retry, since --help false --version false are added to the command line of retry executions and cause protractor to print help and exit.

Suggested solution:
Filtered out help and version arguments from protractor parameters for retry execution.

Reference:

• Changelog for v9.0.0 - https://github.com/yargs/yargs/blob/master/CHANGELOG.md#900-2017-09-03
• PR with breaking changes: feat: enable .help() and .version() by default yargs/yargs#912

[dreuxl]

thanks for the feedback, I can repro locally. I will try to find some times to work on a fix.

are u blocked by that issue?

[khitrenovich]

Nope, I'm not blocked by that. I just run into the incompatibility and decided to bring it to your attention.

Thank you for handling that!