Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): move formatjs/intl-relativetimeformat to deps #1349

Merged
merged 1 commit into from
Jul 3, 2019
Merged

fix(deps): move formatjs/intl-relativetimeformat to deps #1349

merged 1 commit into from
Jul 3, 2019

Conversation

ipanasenko
Copy link
Contributor

it was in devDependencies, but is actually a production dependency

@ipanasenko
fix(deps): move formatjs/intl-relativetimeformat to deps
9cc646c 
it was in devDependencies, but is actually a production dependency
@longlho
Copy link
Member

longlho commented Jul 3, 2019

Thanks a lot for your PR. It is actually not a production dependency bc it's a polyfill (Chrome/FF don't need it)

@longlho longlho closed this Jul 3, 2019
@ipanasenko
Copy link
Contributor Author

ipanasenko commented Jul 3, 2019 •
edited
Loading

I mean, you require Unit from it in types, and I got an error that this module is not found. Sorry I didn't say it in PR description

@longlho longlho reopened this Jul 3, 2019
@longlho
Copy link
Member

longlho commented Jul 3, 2019

gotcha. That makes sense.
Thanks a lot for your contributions!

@longlho longlho merged commit 310bb62 into formatjs:master Jul 3, 2019
@ipanasenko ipanasenko deleted the patch-1 branch July 3, 2019 15:38
@longlho longlho added this to the v3.0.0 milestone Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ipanasenko @longlho