Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade formatjs dev #1357

Merged
merged 1 commit into from
Jul 9, 2019
Merged

feat: upgrade formatjs dev #1357

merged 1 commit into from
Jul 9, 2019

Conversation

longlho
Copy link
Member

@longlho longlho commented Jul 9, 2019

Newer versions has new AST & better perf

Before

<div> x 2,028,960 ops/sec ±3.31% (83 runs sampled)
100 x <div/> x 10,623 ops/sec ±4.06% (77 runs sampled)
100 x <FormattedNumber> x 1,418 ops/sec ±7.83% (76 runs sampled)
100 x <FormattedDate> x 692 ops/sec ±3.88% (76 runs sampled)
100 x <FormattedMessage> x 2,866 ops/sec ±3.96% (89 runs sampled)
100 x <FormattedMessage> with placeholder x 56.80 ops/sec ±12.36% (51 runs sampled)
100 x <FormattedMessage> with placeholder in AST form x 110 ops/sec ±2.44% (70 runs sampled)
100 x <FormattedMessage> with placeholder, cached x 473 ops/sec ±9.41% (63 runs sampled)
100 x <FormattedMessage> with placeholder, cached in AST form x 119 ops/sec ±6.87% (56 runs sampled)

After

<div> x 2,111,875 ops/sec ±2.44% (90 runs sampled)
100 x <div/> x 12,008 ops/sec ±1.31% (89 runs sampled)
100 x <FormattedNumber> x 1,982 ops/sec ±0.99% (91 runs sampled)
100 x <FormattedDate> x 830 ops/sec ±2.12% (86 runs sampled)
100 x <FormattedMessage> x 2,981 ops/sec ±0.92% (88 runs sampled)
100 x <FormattedMessage> with placeholder x 76.83 ops/sec ±9.83% (69 runs sampled)
100 x <FormattedMessage> with placeholder in AST form x 206 ops/sec ±1.12% (79 runs sampled)
100 x <FormattedMessage> with placeholder, cached x 573 ops/sec ±1.07% (84 runs sampled)
100 x <FormattedMessage> with placeholder, cached in AST form x 392 ops/sec ±4.28% (82 runs sampled)

@longlho longlho requested a review from redonkulus July 9, 2019 02:33
@longlho longlho merged commit 61b536b into master Jul 9, 2019
@longlho longlho deleted the dev branch July 9, 2019 03:51
@longlho longlho added this to the v3.0.0 milestone Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants