feat: Allow formatting embedded XML #1379
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhanced
FormattedMessage
&formatMessage
rich text formattingIn v2, in order to do rich text formatting (embedding a
ReactElement
), you had to do this:Now you can do:
The change solves several issues:
link
effectively is a blackbox placeholder to a translator. It can be a person, an animal, or a timestamp. Conveying contextual information viadescription
&placeholder
variable is often not enough since the variable can get sufficiently complicated.However, in cases where we allow placeholders to be a ReactElement will have to be rewritten to 1 of the 2 syntax down below:
Before
After
OR (NOT RECOMMENDED)