Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

morphTo()->withTrashed() ERROR: Call to undefined method Yajra\Oci8\Query\OracleBuilder::withTrashed() #192

Open
chrislandeza opened this issue Aug 5, 2016 · 1 comment
Labels

Comments

@chrislandeza
Copy link

chrislandeza commented Aug 5, 2016

I have this method on my model:

   /**
     * Grab the revision history for the model that is calling 
     *
     * @return array revision history
     */
    public function revisionable()
    {
        return $this->morphTo()->withTrashed();
    }

This is basically a modified version of: https://github.com/VentureCraft/revisionable to include softdeleted data.
Perfectly working on mysql driver, but when I switched to oracle with this package Im getting an error:
Call to undefined method Yajra\Oci8\Query\OracleBuilder::withTrashed()

This error also occured in Laravel core:
laravel/framework#13886

But they already fixed it:
laravel/framework#13828

I'm using Laravel Framework version 5.2.41

Bug?

@yajra
Copy link
Owner

yajra commented Aug 5, 2016

@chrislandeza this seems like a bug. If you can, please do not hesitate to submit a PR. I rarely used morph and soft deletes so this might took me some time to verify and fix.

@yajra yajra added the bug label Aug 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants