Using dot-writer library

[DrGabble]

Would you be averse to me refactoring your graphviz code to use my new dot-writer library? Largely for my own selfish reasons (so I can put it through its paces and put it out in the world a bit), but arguably it could make your code more readable, strongly typed and terser?

Happy to do the pull request myself of course (I might have to anyway as it might be missing a function here or there that your dot output needs), and equally understand if you'd like to minimize dependancies / leave things as they are.

[yamafaktory]

Hi @DrGabble and thanks for the feedback!

Please don't mind the conversion from an (non-) issue to a discussion.

Two things regarding your proposal:

• I'm not sure yet if I want to bloat the project with another dependency. Rendering to dot format is more like a bonus.. and indeed a good way to visually check the hypergraph!
• The current implementation is mostly taken from petgraph - with a bunch of adjustments since here we deal with hypergraphs. Since the dot format is not initially made to represent hypergraphs, what is essential is to keep features like unaries, self-loops and the fact that it should remain non-simple (see https://en.wikipedia.org/wiki/Hypergraph#Properties_of_hypergraphs). All those things are already working with the current dot output.

If you still feel motivated, feel free to create a pull-request.

N.B.: if you're looking for more traction / exposure for your crate, it might interesting to have a look at https://github.com/petgraph/petgraph since they also output to dot format.

[DrGabble]

Ah no worries, thanks for letting me down gently lol yeah objectively it's not worth the dependency bloat, but thought I'd ask just in the off chance :) yes petgraph is my next port of call! I actually wrote the library to render my petgraph structures so makes sense. Best of luck!

[glyn]

* The current implementation is mostly taken from _petgraph_

It would be great to acknowledge that in the README, along with a link to petgraph.

[yamafaktory]

Hi @glyn. To be precise, the whole implementation is not taken from petgraph (which doesn't render hypergraphs anyway). The source is acknowledging the borrowed part here https://github.com/yamafaktory/hypergraph/blob/main/src/core/debug.rs#L9. But you're right, the README definitely needs some refactoring.

[glyn]

Perfect.

[yamafaktory]

Thanks @DrGabble! I'm not letting you down but I'm afraid that this might suck your time for... maybe for something not worth the effort. If you're ultra motivated, I would be glad to accept your pull-request :).

[DrGabble]

@yamafaktory You overestimate how useful my time is! I've made a branch locally :) it's my first time pushing branches to github however... I don't seem to be able to make branches so I can do a pull request? Do i need to be granted permissions or something?

[yamafaktory]

Hi @DrGabble ! You don't need any specific permissions to create a pull-request if your branch is simply based on a fork you did on GitHub. You can follow those steps here https://docs.github.com/en/github/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork.