Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin type defaults #39

Open
skipor opened this issue Apr 5, 2017 · 1 comment
Open

Plugin type defaults #39

skipor opened this issue Apr 5, 2017 · 1 comment

Comments

@skipor
Copy link
Contributor

skipor commented Apr 5, 2017

Every plugin implementation can have it's own defaults. But user still needed to set 'type' field for every plugin.
I propose to add default types for every plugin.

@skipor skipor self-assigned this Apr 5, 2017
@skipor
Copy link
Contributor Author

skipor commented Jul 24, 2017

I think, it's possible do more magic things! Maybe auto deduce plugin type?
Iterate over all plugins and check if data "suitable" for this plugin config type.
"suitable" may mean, decoded without errors (do not create plugin, just decode config without validation), or check, that data keys is subset of config keys (may be harder).
If no plugin type suitable - error. If more than one plugin type suitable - error.

rps:
   composite:
      - {from: 10, to: 50, duration: 3m}
      - {ops: 50, duration: 5m}
      - {once: 100}
      - {from: 50, to: 10, duration: 2m}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant