-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The decision is made at compile time rather than run time #18
Comments
Thanks for opening this issue, the readme lacks information on this. Now, The Readme is updated to help people know how to use, and why this can not be solved now. Currently, this repo can provide build-time ignoring check but not runtime ignoring check, and helps users build and test a larger application with much more integration. By the way, there is also an RFC related to this crate, you may check it out. |
Ah, sorry. I’ve actually skipped the README and didn’t notice that this was already mentioned there. |
Don't worry. Once we can ignore the test case in the test case itself, I will refactor this. |
I’ve actually run into #68007 (which is in fact how I’ve discovered your crate) but then the linked pre-RFC has been dead since October and there seems to be nothing happening regarding this feature. I’ve been actually thinking about creating RFC myself if there’s no progress on the process. |
The RFC happens only someone keeps pushing and taking care of it, If you create an RFC on this, please let me know, and I am willing to help and learn more from this. Thanks. |
I’ve written a draft and plan to submit it later in a few days: https://github.com/mina86/rfcs/blob/master/text/0000-ignore-if.md |
It may be good just call |
This would leave |
It is good to discuss with the public under |
FYI, rust-lang/rfcs#3221 |
This issue can be fixed after this PR is merged. |
The text was updated successfully, but these errors were encountered: