Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multi-architecture Docker image #196

Closed
denisa opened this issue Apr 24, 2023 · 6 comments
Closed

Support multi-architecture Docker image #196

denisa opened this issue Apr 24, 2023 · 6 comments

Comments

@denisa
Copy link
Contributor

denisa commented Apr 24, 2023

Apple is transitioning its computer to a arm64 architecture

While amd64 can be executed, sometime, this is slower.

Could the project build an image that supports both amd64 and arm64?.

@yannh
Copy link
Owner

yannh commented May 13, 2023

What would you think of arm64 images, like with a -arm64 suffix? That should be pretty trivial to add :)

@denisa
Copy link
Contributor Author

denisa commented May 14, 2023

Do you mean https://goreleaser.com/cookbooks/multi-platform-docker-images/?h=multi ?

In the ideal end-state, there is a single image and docker dynamically downloads what’s appropriate at execution time

@yannh
Copy link
Owner

yannh commented May 14, 2023

I tried adding support for separate arm64 images here https://github.com/yannh/kubeconform/actions/runs/4971934488/jobs/8896808560 but hit some issues and reverted for now. This is also pretty difficult for me to test - since I do not own a mac.
I don't have much more time today, but would happily merge PRs to add support here. Also happy to add support for multi-arch images.

@denisa
Copy link
Contributor Author

denisa commented May 15, 2023

See #204

@yannh
Copy link
Owner

yannh commented Jul 16, 2023

Closing, since the PR has been merged, thanks!

1 similar comment
@yannh
Copy link
Owner

yannh commented Jul 16, 2023

Closing, since the PR has been merged, thanks!

@yannh yannh closed this as completed Jul 16, 2023
@yannh yannh closed this as completed Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants