Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prop-types false positive outside of component and false negative in component #485

Closed
billyjanitsch opened this issue Mar 4, 2016 · 0 comments

Comments

@billyjanitsch
Copy link

Ran into the following issue -- apologies if it's a duplicate; my search of existing issues didn't turn up anything similar.

export const TestComponent = props =>
  <div onClick={() => props.test()} /> // no error

export const mapStateToProps = (_, props) => ({
  otherProp: props.otherProp, // 'otherProp' is missing in props validation
})

Expected: props.test() should throw a prop-types error since TestComponent has no propTypes defined.

Also expected: the props.otherProp in mapStateToProps should not throw since mapStateToProps is not a component.

eslint: 2.2.0
eslint-plugin-react: 4.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant