Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False positive for react/jsx-pascal-case on namespaced components #637

Closed
strawbrary opened this issue Jun 16, 2016 · 3 comments
Closed

False positive for react/jsx-pascal-case on namespaced components #637

strawbrary opened this issue Jun 16, 2016 · 3 comments

Comments

@strawbrary
Copy link

In v5.2.0 I'm getting a false positive for the react/jsx-pascal-case rule when using namespaced components.

<Modal show={showModal} onHide={this.closeModal}>
  <Modal.Header closeButton>
    <Modal.Title>Demo</Modal.Title>
  </Modal.Header>
</Modal>

It looks like it was introduced in cd5ef2b.
@ljharb
Copy link
Member

ljharb commented Jun 16, 2016

ping @evcohen

@beefancohen beefancohen mentioned this issue Jun 16, 2016
Merged
@beefancohen
Copy link
Contributor

sorry bout that 😢
re: /pull/638

yannickcr pushed a commit that referenced this issue Jun 16, 2016
@beefancohen @yannickcr
Fix jsx-pascal-case for JSXMemberExpressions (fixes #637)
ef406fa
@yannickcr
Copy link
Member

No problem @evcohen, thanks for the very quick fix 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@yannickcr @ljharb @strawbrary @beefancohen