-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bumps deps; peerDeps allows ESLint 2 or 3 #657
Conversation
Wouldn't it be wiser to wait on updating the rule format, so there can be a version of the plugin that supports both eslint 2 and eslint 3 for awhile? |
@ljharb my changes here are just a proposal of course, with the maintainers having final say. I made these changes assuming that the MAJOR SemVer number would be bumped, so ESLint 2 users could still use the previous version without any problems. Do we want to continue making changes to the ESLint 2 version of this plugin? Or can we safely leave it as-is? |
Yes, ideally we would keep making changes to the eslint "2 + 3" version for awhile, so as to give eslint 2 users (and node 0.10 users) as smooth an upgrade path as possible, for as long as possible. The only time this PR will become necessary is after eslint v4 comes out, so I'm inclined not to rush it. |
Okay. If I get time later, I'll change this PR to keep the old ESLint 2 rule format. Or, someone else can beat me to it by creating a less turbulent PR. :) |
@ljharb okies, I've removed all rule format changes, this is purely about enabling usage with ESLint 3 without touching existing support for ESLint 2 |
@@ -27,12 +27,18 @@ | |||
"jsx-ast-utils": "^1.2.1" | |||
}, | |||
"devDependencies": { | |||
"babel-eslint": "6.0.5", | |||
"babel-eslint": "^6.0.5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this not be bumped to 6.1.0?
LGTM |
What's blocking this from being merged? |
@yannickcr it'd be great to get a release of this :-) |
@ljharb Thanks for your help, I'm a bit late on this :( I'll try to do a release tomorrow. |
@yannickcr thanks! looking forward to releasing a new eslint-config-airbnb ;-) |
@jokeyrhyme turns out eslint v2 supports the new rule format already (import-js/eslint-plugin-import#406 (comment)) so if you'd like to make a new PR that upgrades the rules, id be happy to merge it :-) |
@ljharb woah, that's really good planning on ESLint's part. I'll see how extra-curricular I'm feeling this weekend. :) |
@ljharb Since adding a peerDepencency is a big change I prefer to consider it as a breaking change. I am not ready yet to publish the |
@yannickcr understood - in this case I don't think anybody is still using eslint v1 with eslint-plugin-react, but it's good to be cautious. I won't be able to release an updated eslint-config-airbnb without a non-alpha eslint-plugin-react anyways, but as you can see I've got a few more blockers, so within the next week or so would be ideal if that's ok :-) |
Do you have a GitHub Milestone for 6.0, or a list somewhere? Want some help? |
@ljharb @jokeyrhyme I do not have a lot of time this week but I'll try to do an roadmap before the week-end (like I made for 4.0 #436) |
npm
users identify compatibility issues