Repair --fix for props-aligned in jsx-closing-bracket-location
#684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the correctColumn attribute
|
Mmm, I don't quite see what is the current problem. Can you add a test that reproduce it and that is fixed with your patch? |
|
@yannickcr sure - the test I've added fails on master. This is a modifed example taken from our own codebase that was the impetus for this change. |
| ' );', | ||
| '};' | ||
| ].join('\n'), | ||
| options: ['props-aligned'], |
There was a problem hiding this comment.
can we also add a test for the "line-aligned" option? We might want to add explicit tests for all of them.
There was a problem hiding this comment.
I added a similar test for line-aligned and tag-aligned
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the correctColumn attribute that is populated above.
I don't quite understand the error, but running with
--fixI would still get errors that look like" 247:37 error The closing bracket must be aligned with the last prop (expected column 9) react/jsx-closing-bracket-location"
But with this change,
--fixdoes the right thing.