Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add context props to sort-comp #89

Merged
merged 1 commit into from
May 29, 2015
Merged

Add context props to sort-comp #89

merged 1 commit into from
May 29, 2015

Conversation

zertosh
Copy link
Contributor

@zertosh zertosh commented May 29, 2015

Although technically undocumented, context is very widely used, and it sucks to have to override lifecycle to just fit them in.

I don't really have a strong opinion on where they fit in the order, but I kinda based it on the order in which they're defined in https://github.com/facebook/react/blob/52752446760dee0bc7232b4146f5a309ac57f065/src/isomorphic/classic/class/ReactClass.js#L115-L159. I can put them in any other order if you'd like.

@mathieumg
Copy link
Contributor

Sure, why not! 👍

@Cellule
Copy link
Contributor

Cellule commented May 29, 2015

That order seems fine and since we can always override it if desired then I'd say this is pretty good.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.47% when pulling ec1c62b on zertosh:more-sort-comp into ab7d219 on yannickcr:master.

@yannickcr
Copy link
Member

Seems fine to me too, great addition!

yannickcr added a commit that referenced this pull request May 29, 2015
Add context props to sort-comp
@yannickcr yannickcr merged commit 3da7535 into jsx-eslint:master May 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants