-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Readme need to Update (Suggestion) for oauth app #125
Comments
GitHub APP can be also used as an oauth app. Maybe we could change the title and add some comments for refresh token in the code. |
Please do not open this, my account got compromised. I’m very sorry about that. |
what will be if we update documentation like Develop an OAuth APP/GitHub APP with web flow
still I amnot able to figure out how to get user email
|
you can just open a pr and i will review it.
|
I found that the refresh_token will become invalid once it is used and user should store the new refresh token. I miss this in the docs. I will add this later.
|
Develop an OAuth APP with web flow
I think these need to be updated as
There is no opt-in feature available on oauth app but github app provide this feature. that a reason , oauth app always return accesstoken instead of refresh_token . I think , we shouldnot need to mention refresh_token as it's value is always None.
and I can't able to get user email directly from above user object like
so to get email address , we have to do like
If all sounds good to you, I will be happy to create PR.
The text was updated successfully, but these errors were encountered: