Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: App auth path matching not work for Enterprise #52

Closed
yanyongyu opened this issue Oct 13, 2023 · 1 comment · Fixed by #53
Closed

Bug: App auth path matching not work for Enterprise #52

yanyongyu opened this issue Oct 13, 2023 · 1 comment · Fixed by #53
Labels
bug Something isn't working Rest API

Comments

@yanyongyu
Copy link
Owner 

          This change breaks github enterprise, because urls begin with /api/v3, this regex no longer matches for the /app endpoint

Originally posted by @brainiac in #42 (comment)
@yanyongyu yanyongyu added bug Something isn't working Rest API labels Oct 13, 2023
@yanyongyu
Copy link
Owner Author

octokit matches the path by replacing the base url first:

https://github.com/octokit/auth-app.js/blob/c0068e06081a5d930799285a7c79c9c948b676b6/src/hook.ts#L43

@yanyongyu yanyongyu mentioned this issue Oct 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Rest API
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: enterprise auth type detect yanyongyu/githubkit
1 participant
@yanyongyu