Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Node.js versions and binaries for Feb 14 security releases #27

Closed
jcoglan opened this issue Feb 15, 2024 · 6 comments
Closed

Update Node.js versions and binaries for Feb 14 security releases #27

jcoglan opened this issue Feb 15, 2024 · 6 comments

Comments

@jcoglan
Copy link

jcoglan commented Feb 15, 2024

Node.js just announced new releases of v18, v20 and v21 to address a number of security vulnerabilities. They are patched in v18.19.1, v20.11.1, and v21.6.2.

It looks as though this fork has been keeping up to date with new releases -- thank you very much :) -- so I'm just opening this issue to check if/when these security patches will make it into the pkg binaries so we can ship new builds with them.

@robertsLando
Copy link
Member

#28 #29

@janl
Copy link

janl commented Feb 15, 2024

no rush or anything, but what’s the expected turnaround time on the binary build? We know it takes quite a while to build all this from scratch.

Also, are you looking for help with all this, and how can we best help you?

@viceice
Copy link

viceice commented Feb 15, 2024

builds are stuck pending, they probably needs manual intervention

@robertsLando
Copy link
Member

I have created a GH workflow that will help me with patches, this is the first time I use it and it seems to work great (and will be a time saver). Problem is only when patches don't apply correctly, that will require me to manually patch them.

I only forgot to make my workflow update the patches reference file, I will do it manually now and update the workflow. The most time then is needed to build the patches (takes many hours to build them all, expecially the macos ones that take ~5h) then bump shas, create and merge the sha bump pr, make a release of pkg-fetch and then bump it on pkg and release that too (I created a dedicated document to explain the release process as it has been a pain to track down.

If you want to help consider supporting me: https://github.com/sponsors/robertsLando

This was referenced Feb 16, 2024
@robertsLando
Copy link
Member

https://github.com/yao-pkg/pkg-fetch/actions/runs/7928279506

@robertsLando
Copy link
Member

https://github.com/yao-pkg/pkg/releases/tag/v5.11.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants