fix: follow exact SEA baking procedure for Mac #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this @getlarge! 💪 About tests check DEVELOPMENT.md for more informations anyway you could simply uncomment the lines that run the sea binary in test-00-sea/main.js as it wasn't working and should be enough to cover this :) |
Done and passed locally. You can trigger the workflows now! |
robertsLando
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followed the process described in Node.js docs to produce valid binaries for your beloved MacOS fan-base :D.
I tested this locally by patching pkg in one of my repository.
Once my Webpack configuration was adapted to bundle the
node_modulesinto the build output, and after runningnpx pkg main.js --output main -t node20-macos-arm64 --sea --debug, the application was running 🎉.Maybe you can guide me, and tell me where should the tests be written?