Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to replace content instead of appending #48

Closed
trentmwillis opened this issue May 25, 2016 · 1 comment
Closed

Ability to replace content instead of appending #48

trentmwillis opened this issue May 25, 2016 · 1 comment

Comments

@trentmwillis
Copy link

trentmwillis commented May 25, 2016

Looking at the current code, it seems that ember-wormhole only supports appending content into the destination. While this makes sense in a lot of cases, we have a use-case where it would be beneficial to replace the content of the destination instead.

In short, we have a portion of our app being SSR'd and after boot up on the client, we're using ember-wormhole to inject some dynamic content and it works wonderfully. But, for SEO and slower phones, we initially render some placeholder content, which we currently have to manually remove. It would be nice if ember-wormhole could handle that for us.

Edit: if this seems like a reasonable ask, I'll implement it.

@lukemelia
Copy link
Contributor

Closing in favor of discussion on #52

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants