Skip to content

Commit

Permalink
fix: coerce should be applied to the final objects and arrays created (
Browse files Browse the repository at this point in the history
…#57)

BREAKING CHANGE: coerce is no longer applied to individual arguments in an implicit array.
  • Loading branch information
maxrimue authored and bcoe committed Sep 8, 2016
1 parent 2f02003 commit 4ca69da
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 14 deletions.
16 changes: 3 additions & 13 deletions index.js
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,7 @@ function parse (args, opts) {
setConfig(argv)
setConfigObjects()
applyEnvVars(argv, false)
applyArrayCoercions(argv)
applyCoercions(argv)
applyDefaultsAndAliases(argv, flags.aliases, defaults)

// for any counts either not in args or without an explicit default, set to 0
Expand Down Expand Up @@ -483,11 +483,9 @@ function parse (args, opts) {
})
}

function applyArrayCoercions (argv) {
function applyCoercions (argv) {
var coerce
Object.keys(argv).filter(function (key) {
return key === '_' || checkAllAliases(key, flags.arrays)
}).forEach(function (key) {
Object.keys(argv).forEach(function (key) {
coerce = checkAllAliases(key, flags.coercions)
if (typeof coerce === 'function') {
try {
Expand Down Expand Up @@ -538,14 +536,6 @@ function parse (args, opts) {
})

var key = keys[keys.length - 1]
var coerce = !checkAllAliases(key, flags.arrays) && checkAllAliases(key, flags.coercions)
if (typeof coerce === 'function') {
try {
value = coerce(value)
} catch (err) {
error = err
}
}

if (value === increment) {
o[key] = increment(o[key])
Expand Down
16 changes: 15 additions & 1 deletion test/yargs-parser.js
Original file line number Diff line number Diff line change
Expand Up @@ -1980,11 +1980,25 @@ describe('yargs-parser', function () {
parsed.f.should.equal(-99)
})

it('applies coercion function to all dot options', function () {
var parsed = parser(['--foo.bar', 'nananana'], {
coerce: {
foo: function (val) {
val.bar += ', batman!'
return val
}
}
})
parsed.foo.bar.should.equal('nananana, batman!')
})

it('applies coercion function to an implicit array', function () {
var parsed = parser(['--foo', '99', '-f', '33'], {
coerce: {
f: function (arg) {
return arg * -1
return arg.map(function (a) {
return a * -1
})
}
},
alias: {
Expand Down

0 comments on commit 4ca69da

Please sign in to comment.