Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle dot notation boolean options #63

Merged
merged 1 commit into from
Nov 7, 2016
Merged

Conversation

ssonal
Copy link
Contributor

@ssonal ssonal commented Oct 15, 2016

Fixes yargs/yargs#617

On studying the code I found that this bug is being caused by yargs-parser. I think my fix should solve this issue, though I'm not sure if something else breaks because of these changes.

I've tested this modified library with yargs and found that all test cases pass.

@bcoe
Copy link
Member

bcoe commented Nov 4, 2016

@ssonal appreciate this patch, sorry for the slow turn around. Will hopefully have time to do a tiny bit of OSSing this weekend.

@bcoe bcoe merged commit 02c3545 into yargs:master Nov 7, 2016
@bcoe
Copy link
Member

bcoe commented Nov 7, 2016

@ssonal thank you very much for this patch.

@ssonal
Copy link
Contributor Author

ssonal commented Nov 7, 2016

No problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dot-notation boolean flags aren't parsed correctly
2 participants