-
Notifications
You must be signed in to change notification settings - Fork 993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(completion): takes negated flags into account when boolean-negation is set #1509
Merged
bcoe
merged 1 commit into
master
from
feature/1431-complete-no-flags-when-boolean-negation-is-set
Jan 9, 2020
Merged
feat(completion): takes negated flags into account when boolean-negation is set #1509
bcoe
merged 1 commit into
master
from
feature/1431-complete-no-flags-when-boolean-negation-is-set
Jan 9, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warning : either this PR or #1507 will need some conflict-handling before merging, as both impact the same lines in completion.js. EDIT: fixed issue reference |
👍 let's hold off on landing until we have a plan. Perhaps you could make a PR against this PR, for #1508 rather than us having both PRs open at the same time. |
mleguen
force-pushed
the
feature/1431-complete-no-flags-when-boolean-negation-is-set
branch
from
December 18, 2019 09:40
ea3fe04
to
822a200
Compare
@mleguen bother you to rebase? |
bcoe
changed the title
feature(completion): takes negated flags into account when boolean-negation is set
feat(completion): takes negated flags into account when boolean-negation is set
Jan 2, 2020
@bcoe I should have some time to do it next week |
mleguen
force-pushed
the
feature/1431-complete-no-flags-when-boolean-negation-is-set
branch
from
January 8, 2020 10:00
822a200
to
a00aa57
Compare
@bcoe done! |
bcoe
approved these changes
Jan 9, 2020
bcoe
pushed a commit
that referenced
this pull request
Jan 9, 2020
bcoe
deleted the
feature/1431-complete-no-flags-when-boolean-negation-is-set
branch
January 9, 2020 18:55
This was referenced Nov 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1431
When boolean-negation is set: