Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix [object Object] property on describe with object #736

Merged
merged 1 commit into from
Dec 17, 2016
Merged

Fix [object Object] property on describe with object #736

merged 1 commit into from
Dec 17, 2016

Conversation

Janpot
Copy link
Contributor

@Janpot Janpot commented Dec 17, 2016

fixes #735

bcoe
bcoe approved these changes Dec 17, 2016
View reviewed changes
Copy link
Member

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Janpot great catch! thanks for the contribution.

@bcoe bcoe merged commit f755e27 into yargs:master Dec 17, 2016
@Janpot Janpot deleted the fix-object-describe branch December 17, 2016 23:25
@bcoe
Copy link
Member

bcoe commented Dec 29, 2016

@Janpot your fix will be going out with the next release of yargs, is a fairly big one so would love the help testing, to get sneak peek run:

npm cache clear; npm i yargs@next

Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcoe bcoe bcoe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

.describe with object results in [object Object] key
2 participants
@Janpot @bcoe