Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] $$virtual karma unit tests #1508

Closed
1 task done
acls opened this issue Jun 23, 2020 · 2 comments
Closed
1 task done

[Bug] $$virtual karma unit tests #1508

acls opened this issue Jun 23, 2020 · 2 comments
Labels
bug Something isn't working external bug This issue highlights a bug in another project reproducible This issue can be successfully reproduced

Comments

@acls
Copy link

acls commented Jun 23, 2020

  • I'd be willing to implement a fix

Describe the bug

After upgrading to the latest yarn berry and updating my package dependencies my karma unit tests no longer run. The issue seems to be caused by #630 which changed virtual to $$virtual.

For some reason karma changes $$virtual to $virtual. Possibly some type of escaping bug/feature. This seems like a bug in karma, but it works using node_modules, so I would think yarn would want to correct it.

The packageLocation in the .pnp.js file is:
.yarn/$$virtual/karma-jasmine-virtual-d5e825a809/0/cache/karma-jasmine-npm-3.3.1-3b2922b99a-5eda66e5ce.zip/node_modules/karma-jasmine/

But karma ends up requesting:
.yarn/$virtual/karma-jasmine-virtual-d5e825a809/0/cache/karma-jasmine-npm-3.3.1-3b2922b99a-5eda66e5ce.zip/node_modules/karma-jasmine/lib/boot.js

To Reproduce

I created this repo that demonstrates the issue.

Environment if relevant (please complete the following information):

  • OS: Linux
  • Node version 10.21.0
  • Yarn version 2.0.0-rc.36

Additional context

Previous version was 2.0.0-rc.6

@acls acls added the bug Something isn't working label Jun 23, 2020
@merceyz merceyz added reproducible This issue can be successfully reproduced external bug This issue highlights a bug in another project labels Jun 23, 2020
@merceyz merceyz self-assigned this Jun 23, 2020
@merceyz
Copy link
Member

merceyz commented Jun 23, 2020

Upstream issue: karma-runner/karma#3530
Upstream fix: karma-runner/karma#3531

@merceyz merceyz removed their assignment Jun 23, 2020
@acls
Copy link
Author

acls commented Jun 23, 2020

That was quick. Thanks @merceyz!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working external bug This issue highlights a bug in another project reproducible This issue can be successfully reproduced
Projects
None yet
Development

No branches or pull requests

2 participants