Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optionalDependencies are not installed #1001

Closed
wayneashleyberry opened this issue Oct 13, 2016 · 2 comments
Closed

optionalDependencies are not installed #1001

wayneashleyberry opened this issue Oct 13, 2016 · 2 comments

Comments

@wayneashleyberry
Copy link

wayneashleyberry commented Oct 13, 2016

Do you want to request a feature or report a bug?

Bug

What is the current behavior?

Optional dependencies are not installed.

If the current behavior is a bug, please provide the steps to reproduce.

$ yarn add gulp-imagemin
$ cd node_modules
$ ls -l | grep imagemin
drwxr-xr-x   7 Wayne  staff  238 Oct 13 16:31 gulp-imagemin
drwxr-xr-x   7 Wayne  staff  238 Oct 13 16:31 imagemin

What is the expected behavior?

Optional dependencies mentioned in package.json should be installed, as per NPM.

$ npm install --save gulp-imagemin
$ cd node_modules
$ ls -l | grep imagemin
drwxr-xr-x   6 Wayne  staff  204 Oct 13 16:32 gulp-imagemin
drwxr-xr-x   6 Wayne  staff  204 Oct 13 16:32 imagemin
drwxr-xr-x   6 Wayne  staff  204 Oct 13 16:32 imagemin-gifsicle
drwxr-xr-x   6 Wayne  staff  204 Oct 13 16:32 imagemin-jpegtran
drwxr-xr-x   6 Wayne  staff  204 Oct 13 16:32 imagemin-optipng
drwxr-xr-x   6 Wayne  staff  204 Oct 13 16:32 imagemin-svgo

Please mention your node.js, yarn and operating system version.

  • node v6.8.0
  • macOS Sierra
  • yarn v0.15.1
@glenjamin
Copy link

See #789 for more info

TLDR is this is fixed on master.

@wayneashleyberry
Copy link
Author

awesome, thanks @glenjamin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants