Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eslint problem #3535

Closed
bestander opened this issue May 30, 2017 · 3 comments
Closed

eslint problem #3535

bestander opened this issue May 30, 2017 · 3 comments

Comments

@bestander
Copy link
Member

from eslint/eslint#8547 (comment)

This is not a react-scripts issue, but seemingly a Yarn bug.
In https://github.com/cmoesel/eslint-8547, run:

readlink `which ./node_modules/.bin/eslint`

It prints:

../react-scripts/node_modules/eslint-plugin-react/node_modules/eslint/bin/eslint.js
In other words, despite there being a top-level ESLint dependency, Yarn links ./node_modules/.bin/eslint to an inner ./node_modules/react-scripts/node_modules/eslint-plugin-react/node_modules/eslint/bin/eslint.js (?!) rather than expected ./node_modules/eslint/bin/eslint.js.

If Yarn fixes the issue, the problem should go away.

@bestander
Copy link
Member Author

Could this cause the issue #3310?

@cmoesel
Copy link

cmoesel commented May 30, 2017

This is just a continuation of the story already documented in #3332. But... this issue immediately gets down to what is likely the real root of the problem!

@bestander
Copy link
Member Author

With the repro package I can confirm that eslint link in .bin is incorrect

 eslint -> ../react-scripts/node_modules/eslint-plugin-react/node_modules/eslint/bin/eslint.js

Should be

eslint -> ../eslint/bin/eslint.js

Thanks @cmoesel!
Reverting #3310 does not really fix it.

I'll look deeper tomorrow and prepare a patch for 0.25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants