eslint problem

[bestander]

from eslint/eslint#8547 (comment)

This is not a react-scripts issue, but seemingly a Yarn bug.
In https://github.com/cmoesel/eslint-8547, run:

readlink `which ./node_modules/.bin/eslint`

It prints:

../react-scripts/node_modules/eslint-plugin-react/node_modules/eslint/bin/eslint.js
In other words, despite there being a top-level ESLint dependency, Yarn links ./node_modules/.bin/eslint to an inner ./node_modules/react-scripts/node_modules/eslint-plugin-react/node_modules/eslint/bin/eslint.js (?!) rather than expected ./node_modules/eslint/bin/eslint.js.

If Yarn fixes the issue, the problem should go away.

[bestander]

Could this cause the issue #3310?

[cmoesel]

This is just a continuation of the story already documented in #3332. But... this issue immediately gets down to what is likely the real root of the problem!

[bestander]

With the repro package I can confirm that eslint link in .bin is incorrect

 eslint -> ../react-scripts/node_modules/eslint-plugin-react/node_modules/eslint/bin/eslint.js

Should be

eslint -> ../eslint/bin/eslint.js

Thanks @cmoesel!
Reverting #3310 does not really fix it.

I'll look deeper tomorrow and prepare a patch for 0.25