fix uncalled matchers #3027
Merged
fix uncalled matchers #3027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiroppy
reviewed
Apr 1, 2017
| @@ -794,14 +794,14 @@ test.concurrent('install should not continue if integrity check passes', (): Pro | |||
| let reinstall = new Install({}, config, reporter, await Lockfile.fromDirectory(config.cwd)); | |||
| await reinstall.init(); | |||
|
|
|||
| expect(await fs.exists(path.join(config.cwd, 'node_modules', 'yarn.test'))); | |||
| expect(await fs.exists(path.join(config.cwd, 'node_modules', 'yarn.test'))).toBe(true); | |||
There was a problem hiding this comment.
I think it would be better to use toBeTruthy().
There was a problem hiding this comment.
+1 although we use a lot of .toBe(true), we probably should do a one-off search and replace for all places like that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While on something else I noticed some matchers weren't being executed (i.e. just
expect(...)with no assertion), I've fixed them.Test plan
Existing tests pass.