Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix performance issue with multiple lifecycle package scripts #4588

Merged
merged 1 commit into from
Oct 2, 2017
Merged

Fix performance issue with multiple lifecycle package scripts #4588

merged 1 commit into from
Oct 2, 2017

Conversation

vkrol
Copy link
Contributor

@vkrol vkrol commented Sep 29, 2017

Fixes #4551

Summary
#4551 (comment)

Test plan

  • Existing tests pass
  • Manually tested

Copy link
Member

@BYK BYK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish we had a new test to prevent from happening again.

@BYK
Copy link
Member

BYK commented Oct 2, 2017

Thanks a lot!

@BYK BYK merged commit 4fa9f71 into yarnpkg:master Oct 2, 2017
@vkrol vkrol deleted the fix-perfomance-issue-with-multiple-lifecycle-package-scripts branch October 2, 2017 16:47
@vkrol
Copy link
Contributor Author

vkrol commented Oct 2, 2017

Thanks! I thought about the test, but I did not decide how to properly test it :(

joaolucasl pushed a commit to joaolucasl/yarn that referenced this pull request Oct 27, 2017
…cripts (yarnpkg#4588)

**Summary**

Fixes yarnpkg#4551.

See yarnpkg#4551 (comment)

**Test plan**

* Existing tests pass
* Manually tested
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants