Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zip can include itself #10

Closed
stevenh opened this issue Nov 21, 2023 · 0 comments · Fixed by #11
Closed

zip can include itself #10

stevenh opened this issue Nov 21, 2023 · 0 comments · Fixed by #11

Comments

@stevenh
Copy link
Contributor

stevenh commented Nov 21, 2023

If the output file resides in one of source directories the generated zip will include a reference to itself, which is inherently racey and not what the user intended.
@stevenh stevenh changed the title Zip can include itself zip can include itself Nov 21, 2023
stevenh added a commit to stevenh/pzip that referenced this issue Nov 21, 2023
@stevenh
fix: exclude output from archive
8448e59 
Exclude the target output file from the archiving process.

Fixes ybirader#10
@stevenh stevenh mentioned this issue Nov 21, 2023
Merged
stevenh added a commit to stevenh/pzip that referenced this issue Dec 9, 2023
@stevenh
fix: exclude output from archive
6648182 
Exclude the target output file from the archiving process.

Fixes ybirader#10
stevenh added a commit to stevenh/pzip that referenced this issue Dec 9, 2023
@stevenh
fix: exclude output from archive
00d6d9f 
Exclude the target output file from the archiving process.

Fixes ybirader#10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: exclude output from archive stevenh/pzip
1 participant
@stevenh