Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: updating the TimeGAN notebook to support the new version of the API #310

Merged
merged 2 commits into from
Dec 8, 2023

Conversation

cptanalatriste
Copy link
Contributor

@cptanalatriste cptanalatriste commented Oct 20, 2023

Previously, the notebook examples/timeseries/TimeGAN_Synthetic_stock_data.ipynb was not aligned with the new version of the API, that uses the TimeSeriesSynthesizer class. We do have a working example at examples/timeseries/stock_timegan.py. In this PR, I mostly ported the code in stock_timegan.py to TimeGAN_Synthetic_stock_data.ipynb, to have working Jupyter Notebook example of synthetic time series generation.

This PR addresses the issue: #300

@cptanalatriste cptanalatriste changed the title Changing the TimeGAN notebook to support the new version of the API fix: Changing the TimeGAN notebook to support the new version of the API Oct 20, 2023
@fabclmnt fabclmnt changed the title fix: Changing the TimeGAN notebook to support the new version of the API docs: Changing the TimeGAN notebook to support the new version of the API Dec 8, 2023
@fabclmnt fabclmnt changed the title docs: Changing the TimeGAN notebook to support the new version of the API docs: updating the TimeGAN notebook to support the new version of the API Dec 8, 2023
@fabclmnt
Copy link
Contributor

fabclmnt commented Dec 8, 2023

Hi @cptanalatriste,

thank you for your contribution! It is always great to have the examples and documentation updated!

@fabclmnt fabclmnt self-requested a review December 8, 2023 19:48
Copy link
Contributor

@fabclmnt fabclmnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@fabclmnt fabclmnt merged commit d24a57e into ydataai:dev Dec 8, 2023
4 checks passed
fabclmnt added a commit that referenced this pull request Dec 8, 2023
* docs: update docs with GMM and relational database synthesis. (#313)

Co-authored-by: Fabiana Clemente <fabianaclemente@Fabianas-MacBook-Air.local>

* docs: update doppelGANger example (#306)

Co-authored-by: Fabiana <30911746+fabclmnt@users.noreply.github.com>

* Changing the TimeGAN notebook to support the new version of the API (#310)

Co-authored-by: Fabiana <30911746+fabclmnt@users.noreply.github.com>

* chore(deps): update dependency scikit-learn to ==1.3.* (#296)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Fabiana <30911746+fabclmnt@users.noreply.github.com>

* chore(deps): update dependency mkdocstrings to v0.24.0 (#294)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Fabiana <30911746+fabclmnt@users.noreply.github.com>

* chore(deps): update dependency mkdocs to v1.5.3 (#292)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Fabiana <30911746+fabclmnt@users.noreply.github.com>

* chore(deps): update dependency ydata-profiling to v4.6.3 (#244)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Fabiana <30911746+fabclmnt@users.noreply.github.com>

* chore(deps): update dependency streamlit to v1.29.0 (#241)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Fabiana <30911746+fabclmnt@users.noreply.github.com>

* chore(deps): update dependency pytest to v7 (#215)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Fabiana <30911746+fabclmnt@users.noreply.github.com>

---------

Co-authored-by: Fabiana Clemente <fabianaclemente@Fabianas-MacBook-Air.local>
Co-authored-by: Miriam Seoane Santos <68821478+miriamspsantos@users.noreply.github.com>
Co-authored-by: Carlos Gavidia-Calderon <cgavidiac@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants