From aa894f21e85b51f8fcc2f382976200e4efa4b611 Mon Sep 17 00:00:00 2001 From: mrsdizzie Date: Fri, 12 Jun 2020 14:02:14 -0400 Subject: [PATCH] Fix 500 error on repos with no tags (#11870) #11846 Introduced feature to show exact tag on commit view. However if a repo has no tags at all git prints out a separate and unhandled error " No names found, cannot describe anything." Adding --always to the command makes it always use the error in the style of "fatal: no tag exactly matches" even if there are no tags at all. Fixes #11869 Fixes #11868 --- modules/git/commit.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/git/commit.go b/modules/git/commit.go index d6448bf26e925..c06eabfbd468f 100644 --- a/modules/git/commit.go +++ b/modules/git/commit.go @@ -484,7 +484,7 @@ func (c *Commit) GetBranchName() (string, error) { // GetTagName gets the current tag name for given commit func (c *Commit) GetTagName() (string, error) { - data, err := NewCommand("describe", "--exact-match", "--tags", c.ID.String()).RunInDir(c.repo.Path) + data, err := NewCommand("describe", "--exact-match", "--tags", "--always", c.ID.String()).RunInDir(c.repo.Path) if err != nil { // handle special case where there is no tag for this commit if strings.Contains(err.Error(), "no tag exactly matches") {