Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Add cache unit tests #243

Merged
merged 5 commits into from
Mar 11, 2022
Merged

test: Add cache unit tests #243

merged 5 commits into from
Mar 11, 2022

Conversation

karelianpie
Copy link
Member

@karelianpie karelianpie commented Mar 8, 2022 •
edited
Loading

Closes #215

  • Add cache unit tests

karelianpie
karelianpie commented Mar 8, 2022
View reviewed changes
src/cache.ts Outdated Show resolved Hide resolved
@karelianpie karelianpie marked this pull request as ready for review March 9, 2022 04:47
@karelianpie karelianpie mentioned this pull request Mar 9, 2022
Closed
jstashh
jstashh reviewed Mar 9, 2022
View reviewed changes
Copy link
Contributor

@jstashh jstashh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just a comment about the pinning

package.json Outdated Show resolved Hide resolved
FiboApe
FiboApe previously approved these changes Mar 9, 2022
View reviewed changes
Copy link
Collaborator

@FiboApe FiboApe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@karelianpie karelianpie self-assigned this Mar 11, 2022
@xgambitox xgambitox merged commit d998080 into yearn:master Mar 11, 2022
@karelianpie karelianpie deleted the issue-215 branch March 11, 2022 22:40
jstashh pushed a commit that referenced this pull request May 31, 2022
@karelianpie @jstashh
test: Add cache unit tests (#243)
045f1a1 
* test: Add cache unit tests

* test: Add further tests to cache.ts

* fix: Cast prototype to any to allow for mocking private function/getter

* refactor: Remove new line

* build: Downgrade type-fest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xgambitox xgambitox xgambitox approved these changes

@jstashh jstashh jstashh approved these changes

@FiboApe FiboApe Awaiting requested review from FiboApe

Assignees

@karelianpie karelianpie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[WEB-1324-215] Add cache unit tests
4 participants
@karelianpie @xgambitox @jstashh @FiboApe