Implement new GeoInterface traits

[evetion]

GeoInterface 1.0 makes use of Traits, this is a PR to update our pre-1.0 GeoInterface implementation.

Note that I had to add some methods to align with GeoInterface:

• Added getm method, previously not wrapped
• Added getgeom for LineStrings. Technically OGR doesn't expose this (and wants us to use getpoint), but our ngeom does have a switch for Lines.
• Added is3d and ismeasured to be used when getting the the third or fourth coordinate
• Added keys and values to a Feature

I've also added dependencies on GeoInterfaceRecipes, a plot package based on GeoInterface, which previously was integrated into GeoInterface and on Extents, a package defining bounding boxes as NamedTuples.

I also note that much in ArchGDAL doesn't support Z en M coordinates properly, for which I will create a separate issue. In short, many of our creation methods don't result in the correct type (just a Point instead of Point25D etc.). This makes it hard to correctly implement getcoord for the m dimension, as it could be both the third or fourth dimension, depending on the type.

[evetion]

• Benchmark CI doesn't seem to update to latest GeoInterface (still using v0.5.7?)
• Plots recipes are required for the documentation to work @rafaqz

[visr]

Benchmark CI doesn't seem to update to latest GeoInterface (still using v0.5.7?)

That'd be because of Shapefile.jl

ArchGDAL.jl/benchmark/Project.toml

Line 6 in e401e00

Shapefile = "8e980c4a-a4fe-5da2-b3a7-4b4b0353a2f4"

[evetion]

@rafaqz can you take a look here at the convert options? I keep running into ambiguous things, as our suggetion for implementing convert overrides everything, including existing methods such as those for GeoFormatTypes.

  Expression: sprint(print, convert(AG.IGeometry, json)) == "Geometry: POINT (100 70)"
  MethodError: convert(::Type{ArchGDAL.IGeometry}, ::GeoFormatTypes.GeoJSON{String}) is ambiguous. Candidates:
    convert(::Type{T}, source::X) where {T<:ArchGDAL.AbstractGeometry, X<:GeoFormatTypes.GeoJSON} in ArchGDAL at /Users/evetion/code/ArchGDAL.jl/src/convert.jl:48
    convert(::Type{T}, geom::X) where {T<:ArchGDAL.IGeometry, X} in ArchGDAL at /Users/evetion/code/ArchGDAL.jl/src/geointerface.jl:262
  Possible fix, define
    convert(::Type{T}, ::X) where {T<:ArchGDAL.IGeometry, X<:GeoFormatTypes.GeoJSON}

[rafaqz]

We need to dispatch both on ArchGDAL.AbstractGeometry. That will work. Both first arguments need to be equally specific

[evetion]

We need to dispatch both on ArchGDAL.AbstractGeometry. That will work. Both first arguments need to be equally specific.

Well that's what I did first, but it segfaults preparedgeometry tests(!). Something to investigate, but otherwise, I'm leaning towards the idea that only IGeometries should be created from conversion, while all geometries can function as a source. But maybe better as an issue than to keep changing more and more in this PR.

[rafaqz]

Both can be on IGeometry as well I guess? I cant remember the distinctions honestly.

[yeesian]

I'm leaning towards the idea that only IGeometries should be created from conversion, while all geometries can function as a source

Yeah I think this might be a viable approach (or at least it was how I was mentally thinking about things without properly having articulated them anywhere)

[evetion]

Benchmark should be able to run when JuliaGeo/Shapefile.jl#72 is merged and released.

[yeesian]

Overall LGTM, thank you so much!

Might be good to update the top level comment of this PR with the changes.

[rafaqz]

Few minor comments, otherwise LGTM

[evetion]

Ok, I can't merge without review approval from someone 👀. I think it's done, coverage has been increased as asked by @yeesian. I've fixed the comments by @rafaqz and @visr. The benchmark suite seems to require a released ArchGDAL version to test against, so it still fails.

[yeesian]

LGTM, thank you so much for seeing this through!